Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: 📝 Fixes to "Introduction and Goals" and "Deployment View" #46

Merged
merged 3 commits into from
Mar 1, 2025
Merged

docs: 📝 Fixes to "Introduction and Goals" and "Deployment View" #46

merged 3 commits into from
Mar 1, 2025
+15 −11

Conversation

uo288499
Copy link

@uo288499 uo288499 commented Feb 27, 2025 •
edited
Loading

Changes

  • Updated Level1DeploymentDigaram.png adding colours for distinguising better the different elements of the diagram
  • Added all the professors to the stakeholders
  • Clarified how the previous year work will be used
  • Adjusted the number of users for the Perfonmance Efficiency quality goal

@uo288499
docs: 📝 Fixes to "Introduction and Goals" and "Deployment View" secti…
1c39414 
…ons have been made

- Updated Level1DeploymentDigaram.png adding colours for distinguising better the different elements of the diagram\n-Added all the professors to the stakeholders\n-Clarified how the previous year work will be used\n-Adjusted the number of users for the Perfonmance Efficiency quality goal
@uo288499 uo288499 added 📃 type: docs Improvements or additions to documentation 🏛️ cat: design Design related that needs to be decided by the team labels Feb 27, 2025
@uo288499 uo288499 self-assigned this Feb 27, 2025
Diegomcha
Diegomcha requested changes Feb 27, 2025
View reviewed changes
Copy link

@Diegomcha Diegomcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, great work! Just one minor change which I think will improve the diagram.

Diegomcha
Diegomcha approved these changes Feb 27, 2025
View reviewed changes
Copy link

@Diegomcha Diegomcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We resolve the issue through conversation. Great work!

UO288992
UO288992 reviewed Feb 27, 2025
View reviewed changes
Copy link

@UO288992 UO288992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems nice, but the surname I commented must be changed.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

HopeDolangac
HopeDolangac approved these changes Mar 1, 2025
View reviewed changes
Copy link

@HopeDolangac HopeDolangac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

fercalonso
fercalonso approved these changes Mar 1, 2025
View reviewed changes
Copy link

@fercalonso fercalonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@fercalonso fercalonso merged commit bfd0a34 into master Mar 1, 2025
3 checks passed
@Diegomcha Diegomcha mentioned this pull request Mar 2, 2025
Open
@fercalonso fercalonso mentioned this pull request Mar 2, 2025
Open
@Diegomcha Diegomcha deleted the docs branch March 3, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UO288992 UO288992 UO288992 left review comments

@Diegomcha Diegomcha Diegomcha approved these changes

@HopeDolangac HopeDolangac HopeDolangac approved these changes

@fercalonso fercalonso fercalonso approved these changes

Assignees

@uo288499 uo288499

Labels
🏛️ cat: design Design related that needs to be decided by the team 📃 type: docs Improvements or additions to documentation
Projects
None yet
Milestone
2. Prototype v0.1 + 2nd deployment
Development

Successfully merging this pull request may close these issues.
5 participants
@uo288499 @Diegomcha @HopeDolangac @fercalonso @UO288992