Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update runtime view diagrams and descriptions #45

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Conversation

fercalonso
Copy link

Summary

  • Updated descriptions for the login, game, and history sections.
  • Ensured clarity in state diagram explanations.

Changes

  • Updated 06_Login.png, 06_Game.png, 06_History.png descriptions.
  • Fixed grammar and spelling issues in runtime view documentation.

Related Issues

#41

2 of the diagrams were not working.

All of them were substituted by the embedded image version.
@fercalonso fercalonso added the 📃 type: docs Improvements or additions to documentation label Feb 26, 2025
@Diegomcha Diegomcha added the 🏛️ cat: design Design related that needs to be decided by the team label Feb 26, 2025
@Diegomcha Diegomcha removed their assignment Feb 26, 2025
@Diegomcha Diegomcha self-requested a review February 26, 2025 20:50
Fix a relation Gateway -> StatsService
Copy link

@Diegomcha Diegomcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a few changes. If you don't understand what I mean please let me know so I can explain myself and we can reach an agreeement.

Gateway and QuestionsService interaction was incorrectly described.
QuestionService is reached by the Gateway through GameService
Copy link

@Diegomcha Diegomcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues were fixed. Great work!

@Diegomcha Diegomcha merged commit 9f94652 into master Feb 26, 2025
3 checks passed
Diegomcha pushed a commit that referenced this pull request Mar 2, 2025
Diegomcha added a commit that referenced this pull request Mar 2, 2025
commit a979665
Merge: e60b874 85f9a59
Author: Pablo González <[email protected]>
Date:   Mon Feb 24 12:55:06 2025 +0100

    Merge pull request #45 from Arquisoft/fix_llmkey_exposure_v2

    Fix llmkey exposure v2

commit 85f9a59
Author: pglez82 <[email protected]>
Date:   Mon Feb 24 12:28:16 2025 +0100

    updating docker compose

commit 70ae7ed
Author: pglez82 <[email protected]>
Date:   Mon Feb 24 11:09:36 2025 +0100

    modifying readme

commit e5dd604
Author: pglez82 <[email protected]>
Date:   Mon Feb 24 11:01:33 2025 +0100

    removing api key from docker image

commit e60b874
Author: pglez82 <[email protected]>
Date:   Thu Feb 20 11:05:29 2025 +0100

    checking change

commit 294aaa3
Merge: 25a54d1 b9e7e1b
Author: Pablo González <[email protected]>
Date:   Thu Feb 20 11:04:55 2025 +0100

    Merge pull request #30 from Arquisoft/fix_llmkey_exposure

    Fix llmkey exposure

commit b9e7e1b
Author: pglez82 <[email protected]>
Date:   Mon Feb 17 23:37:11 2025 +0100

    modify readme

commit d527833
Author: pglez82 <[email protected]>
Date:   Mon Feb 17 22:59:20 2025 +0100

    fixing tests

commit 7f08852
Author: pglez82 <[email protected]>
Date:   Mon Feb 17 22:43:47 2025 +0100

    fixing api key exposure

commit 25a54d1
Author: Pablo González <[email protected]>
Date:   Mon Feb 17 19:46:15 2025 +0100

    Update Dockerfile

commit 16d7927
Author: Pablo González <[email protected]>
Date:   Mon Feb 17 19:12:41 2025 +0100

    Update Dockerfile

commit 03f29ba
Author: Pablo González <[email protected]>
Date:   Mon Feb 17 19:09:04 2025 +0100

    Update Dockerfile

commit df799ec
Author: pglez82 <[email protected]>
Date:   Fri Feb 7 12:44:19 2025 +0100

    add code to deploy

commit 54babf4
Author: pglez82 <[email protected]>
Date:   Fri Feb 7 12:31:03 2025 +0100

    updating api endpoint

Signed-off-by: Diego <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ cat: design Design related that needs to be decided by the team 📃 type: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants