feat: save subset of variables #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mypy complained of incompatible type `**dict[str, int]` This way, it is also robust to future refactorings of the parameter names.
maurosilber
force-pushed
the
save-subset
branch
from
76c908a to
9db5f36
Compare
|
Done! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this changes are built on top of the changes from #34, adding the type annotations for sparsity. I can remove that if you do not want to merge #34.
Allow to save a subset of the variables of the model, which can be relevant for large models, but I can understand if you prefer to keep the codebase simple.