Skip to content

Commit

Permalink
REFACTOR: Folder structure for images, preview image, cta for dowload…
Browse files Browse the repository at this point in the history
…ing resume (#4)

* chore: added cta for downloading resume, directly open links instead of opening a popup

* chore: deleted unused component

* refactor: updated folder structure of images, updated preview image

* chore: removed heroloader component

* refactor: moved batlogo image to misc folder

* chore: updated image dimensions for preview image

---------

Co-authored-by: ArjunGTX <[email protected]>
  • Loading branch information
ArjunGTX and arjun-findr authored Dec 19, 2024
1 parent 9291acf commit b53c235
Show file tree
Hide file tree
Showing 12 changed files with 37 additions and 88 deletions.
File renamed without changes
Binary file added images/meta/preview.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes
Binary file removed images/preview.png
Binary file not shown.
Binary file removed public/videos/loader.webm
Binary file not shown.
28 changes: 26 additions & 2 deletions src/app/_components/HeroCopy.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React from "react";
import { HeroCta } from "./HeroCta";
import { CustomLink } from "@/components/CustomLink";
import { ExternalLinks } from "@/utils/constants";

export const HeroCopy = () => {
return (
Expand All @@ -14,7 +15,30 @@ export const HeroCopy = () => {
don&apos;t care what happens to me.&rdquo;
</i>
</p>
<HeroCta />
<div className="flex justify-center flex-wrap items-center gap-4">
<CustomLink
variant="primary"
className="no-underline flex text-sm md:text-base flex-col justify-center items-center group w-64"
href={ExternalLinks.meeting}
target="_blank"
>
SUMMON THE KNIGHT
<small className="text-gray-400 group-hover:text-gray-200 group-focus-visible:text-gray-200">
(Schedule a call)
</small>
</CustomLink>
<CustomLink
variant="primary"
className="no-underline flex flex-col text-sm md:text-base justify-center items-center group w-64"
href={ExternalLinks.resume}
target="_blank"
>
VIGILANTE PROFILE
<small className="text-gray-400 group-hover:text-gray-200 group-focus-visible:text-gray-200">
(Download resume)
</small>
</CustomLink>
</div>
</div>
);
};
55 changes: 0 additions & 55 deletions src/app/_components/HeroCta.tsx

This file was deleted.

7 changes: 1 addition & 6 deletions src/app/_components/HeroSection.tsx
Original file line number Diff line number Diff line change
@@ -1,17 +1,12 @@
import React from "react";
import dynamic from "next/dynamic";
import { HeroSectionLoader } from "./HeroSectionLoader";
import { HeroCopy } from "./HeroCopy";
import { PageSection } from "./PageSection";

const BatLogo = dynamic(
() => import("./BatLogo").then((module) => module.BatLogo),
{
loading: () => (
<div className="w-full flex justify-center items-center">
<HeroSectionLoader />
</div>
),
loading: () => <></>,
},
);

Expand Down
18 changes: 0 additions & 18 deletions src/app/_components/HeroSectionLoader.tsx

This file was deleted.

2 changes: 1 addition & 1 deletion src/components/Button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export type ButtonVariant = "primary";

export const variantClasses: Record<ButtonVariant, string> = {
primary:
"border border-gray-500 rounded-md border-solid text-white/80 bg-black/70 backdrop-blur-sm py-3 px-10 focus-visible:[&:not(:disabled)]:text-white hover:[&:not(:disabled)]:border-white/50 hover:[&:not(:disabled)]:text-white disabled:opacity-30",
"border border-gray-500 rounded-md border-solid text-white/80 bg-black/70 backdrop-blur-sm py-3 px-5 focus-visible:[&:not(:disabled)]:text-white hover:[&:not(:disabled)]:border-white/50 hover:[&:not(:disabled)]:text-white disabled:opacity-30",
};

export interface ButtonProps
Expand Down
2 changes: 1 addition & 1 deletion src/lib/tsparticles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ export const batLogoOptions: RecursivePartial<IOptions> = {
},
scale: 1,
type: "inline",
url: "/images/batlogo.svg",
url: "/images/misc/batlogo.svg",
position: {
x: 50,
y: 50,
Expand Down
13 changes: 8 additions & 5 deletions src/utils/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ export const getMetaData = (options?: {
icons: [
{
rel: "icon",
url: "/images/favicon.webp",
url: "/images/meta/favicon.webp",
type: "image/webp",
},
],
twitter: {
Expand All @@ -41,10 +42,11 @@ export const getMetaData = (options?: {
card: "summary_large_image",
images: [
{
url: `${Constants.frontendUrl}/images/preview.webp`,
height: 630,
url: `${Constants.frontendUrl}/images/meta/preview.webp`,
height: 600,
width: 1200,
alt: "Developer by day, vigilante by night.",
type: "image/webp",
},
],
creator: "@im_arjunvc",
Expand All @@ -56,10 +58,11 @@ export const getMetaData = (options?: {
locale: "en_US",
images: [
{
url: `${Constants.frontendUrl}/images/preview.webp`,
height: 630,
url: `${Constants.frontendUrl}/images/meta/preview.webp`,
height: 600,
width: 1200,
alt: "Developer by day, vigilante by night.",
type: "image/webp",
},
],
title,
Expand Down

0 comments on commit b53c235

Please sign in to comment.