Upgrade Serilog to 4.0.x #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use new wrapper sink construction - remove Serilog.Sinks.PeriodicBatching - use IBatchedLogEventSink from core serilog package
|
@nblumhardt Could you take a look at this PR? I'm wondering if I implemented the new Periodic Batching and Wrapping Sink |
|
Hi @ArieGato, The switch to the Serilog 4 batching configuration looks good 👍 I've been doing some work on a built-in fallback-logging implementation that seems like it would streamline how you're setting up failure sinks in this project; if you have a chance to check it out, any feedback over there would be really helpful: serilog/serilog#2108 Cheers! |
avermunt
approved these changes
Oct 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #212 +/- ##
==========================================
- Coverage 96.28% 96.26% -0.03%
==========================================
Files 8 8
Lines 485 482 -3
Branches 45 45
==========================================
- Hits 467 464 -3
Misses 9 9
Partials 9 9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #210