Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run cardinal editor in world cardinal start #57

Conversation

zulkhair
Copy link
Collaborator

@zulkhair zulkhair commented Apr 4, 2024

Closes: WORLD-1018

Overview

Run cardinal editor in world cardinal start

Brief Changelog

  • add --editor flag to run cardinal editor in world cardinal start command
  • add step to run cardinal editor like dev mode.

Testing and Verifying

  • tested manually by running world cardinal start --editor

Copy link

graphite-app bot commented Apr 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “graphite/merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

zulkhair commented Apr 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @zulkhair and the rest of your teammates on Graphite Graphite

Copy link

coderabbitai bot commented Apr 4, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 56.41026% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 52.69%. Comparing base (06da068) to head (f597cda).

❗ Current head f597cda differs from pull request most recent head b1ac9e0. Consider uploading reports for the commit b1ac9e0 to get more accurate results

Files Patch % Lines
common/teacmd/editor.go 56.41% 16 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   52.69%   52.69%           
=======================================
  Files           9        9           
  Lines         668      668           
=======================================
  Hits          352      352           
  Misses        252      252           
  Partials       64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zulkhair zulkhair force-pushed the daim/world-1018_run_cardinal_editor_in_world_cardinal_start branch from dca1432 to 8fd349e Compare April 4, 2024 15:47
@zulkhair zulkhair force-pushed the daim/world-1016_upgrade_editor_version branch from 1481483 to 9208f6a Compare April 4, 2024 15:51
@zulkhair zulkhair force-pushed the daim/world-1018_run_cardinal_editor_in_world_cardinal_start branch from 8fd349e to f597cda Compare April 4, 2024 15:51
@zulkhair zulkhair marked this pull request as ready for review April 4, 2024 15:54
@zulkhair zulkhair requested review from rmrt1n and smsunarto April 4, 2024 15:54
@zulkhair zulkhair force-pushed the daim/world-1016_upgrade_editor_version branch from 9208f6a to 06da068 Compare April 4, 2024 15:56
@zulkhair zulkhair changed the base branch from daim/world-1016_upgrade_editor_version to main April 4, 2024 15:57
Copy link

graphite-app bot commented Apr 4, 2024

Merge activity

Closes: WORLD-1018

## Overview

Run cardinal editor in world cardinal start

## Brief Changelog
- add `--editor` flag to run cardinal editor in `world cardinal start` command
- add step to run cardinal editor like dev mode.

## Testing and Verifying

- tested manually by running `world cardinal start --editor`
@zulkhair zulkhair force-pushed the daim/world-1018_run_cardinal_editor_in_world_cardinal_start branch from f597cda to b1ac9e0 Compare April 4, 2024 17:12
@graphite-app graphite-app bot merged commit b1ac9e0 into main Apr 4, 2024
5 checks passed
@zulkhair zulkhair deleted the daim/world-1018_run_cardinal_editor_in_world_cardinal_start branch May 30, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants