-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fetch & download cardinal editor on world create #52
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite/merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 52.50% 52.78% +0.28%
==========================================
Files 8 9 +1
Lines 480 629 +149
==========================================
+ Hits 252 332 +80
- Misses 192 235 +43
- Partials 36 62 +26 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Rename and move telemetry cache file inside .worldcli dir instead of direct file.
- Cached cardinal editor in .worldcli dir
81809a6
to
fd476b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 last change and the approved
Co-authored-by: Zulkhair Abdullah Daim <[email protected]>
Closes: WORLD-999
Overview
Sets up Cardinal Editor on
world create
. The set up steps include:{targetDirectory}/.editor
__CARDINAL_PROJECT_ID__
with a guidBrief Changelog
world create
teacmd
packageTesting and Verifying
Added unit test that checks if the editor is setup correct. (though it doesn't check if it works correctly, as the web server isn't implemented yet)