Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use GoReleaser for build & release binary #49

Merged
merged 32 commits into from
Mar 28, 2024

Conversation

heronimus
Copy link
Contributor

@heronimus heronimus commented Mar 22, 2024

Closes: WORLD-971

Overview

  • Implement GoReleaser for build and releasing world-cli binary package.
  • Release can be done in two ways:
    • Create a manual release from GitHub pages, and CI will trigger the GoReleaser to do the build, upload all the binaries, and add the changelog.
    • Or, trigger it locally using make release <tag-version>, and it will automatically create the tag, push it, create the release, and upload all the binary builds.

Brief Changelog

  • add GoReleaser config file (.goreleaser.yml)
  • update make build to use goreleaser cli
  • add make goreleaser-install
  • update CI related workflow for build & release
  • fix Posthog API var missmatch on main branch
  • add make release <tag-version>

Testing and Verifying

  • make install & make clean
    image

  • make release

    • handle wrong/incomplete argument:
      image

    • success release v1.2.5-alpha-5
      image
      image

Copy link

coderabbitai bot commented Mar 22, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.50%. Comparing base (ad580c8) to head (4f8b50b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   52.23%   52.50%   +0.26%     
==========================================
  Files           8        8              
  Lines         448      480      +32     
==========================================
+ Hits          234      252      +18     
- Misses        185      192       +7     
- Partials       29       36       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heronimus heronimus marked this pull request as ready for review March 25, 2024 17:23
@heronimus heronimus requested review from smsunarto and zulkhair March 25, 2024 17:34
Copy link
Collaborator

@zulkhair zulkhair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is gorelease can automatically generate release notes?
I did not see the release notes there. or is that expected?

@heronimus
Copy link
Contributor Author

Is gorelease can automatically generate release notes? I did not see the release notes there. or is that expected?

Oh, I thought it wasn't generated because it's still in pre-release. Turns out it's not turned on by default. I'll check 👀

@smsunarto smsunarto changed the title chore: use GoReleaser for build & release binary ci: use GoReleaser for build & release binary Mar 25, 2024
.goreleaser.yaml Show resolved Hide resolved
makefiles/build.mk Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
makefiles/build.mk Show resolved Hide resolved
makefiles/build.mk Outdated Show resolved Hide resolved
@heronimus heronimus marked this pull request as draft March 25, 2024 20:42
@heronimus
Copy link
Contributor Author

-- still marking this as draft, WIP on make release, need to test the github_token stuff

@heronimus heronimus marked this pull request as ready for review March 27, 2024 16:27
@heronimus
Copy link
Contributor Author

Ready for re-review 🔍 @smsunarto @zulkhair
I've updated the description to include some screenshots of the command.

@heronimus heronimus requested review from zulkhair and smsunarto March 27, 2024 16:38
@smsunarto smsunarto merged commit 07b0545 into main Mar 28, 2024
6 checks passed
@smsunarto smsunarto deleted the heronimus/world-971-goreleaser branch March 28, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants