-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use GoReleaser for build & release binary #49
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 52.23% 52.50% +0.26%
==========================================
Files 8 8
Lines 448 480 +32
==========================================
+ Hits 234 252 +18
- Misses 185 192 +7
- Partials 29 36 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is gorelease can automatically generate release notes?
I did not see the release notes there. or is that expected?
Oh, I thought it wasn't generated because it's still in pre-release. Turns out it's not turned on by default. I'll check 👀 |
-- still marking this as draft, WIP on |
Ready for re-review 🔍 @smsunarto @zulkhair |
Closes: WORLD-971
Overview
make release <tag-version>
, and it will automatically create the tag, push it, create the release, and upload all the binary builds.Brief Changelog
make build
to use goreleaser climake goreleaser-install
make release <tag-version>
Testing and Verifying
make install
&make clean
make release
handle wrong/incomplete argument:
![image](https://private-user-images.githubusercontent.com/29672212/317355057-087d039c-a27f-4ca2-9aa3-20627e2b4e67.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NTU5NzUsIm5iZiI6MTczOTY1NTY3NSwicGF0aCI6Ii8yOTY3MjIxMi8zMTczNTUwNTctMDg3ZDAzOWMtYTI3Zi00Y2EyLTlhYTMtMjA2MjdlMmI0ZTY3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDIxNDExNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE0ZWQyM2IzMDI1MzllZjQwNWI1Y2NjNTVmNzNhYzkwODNmZjU1NDEyZjVjZjIwY2RlMDdlZTc5MTBjZjQzMTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.fTxZ-ZPvhtDylv2MRxiI-6wDzZS7sBKRAlj1oKADPuA)
success release v1.2.5-alpha-5
![image](https://private-user-images.githubusercontent.com/29672212/317346944-a030cc8b-bc19-426f-83c3-03b4ee4f004d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NTU5NzUsIm5iZiI6MTczOTY1NTY3NSwicGF0aCI6Ii8yOTY3MjIxMi8zMTczNDY5NDQtYTAzMGNjOGItYmMxOS00MjZmLTgzYzMtMDNiNGVlNGYwMDRkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDIxNDExNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUxNDNjZDAzNzk3MmRlMmZhMWIzNzAyMjhiNTAxMTQ3MDg5YzQ3ODFiMWVkNjFlZGM5NzhhOGQ4ODQ3ZTJiNjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.x-Spxw9u751qkpAXNQgZSkeqOKksye-g9Y8Z7bRFGyA)
![image](https://private-user-images.githubusercontent.com/29672212/317347219-b1cb0ff2-e859-4c7f-b9bd-06ecd007d132.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NTU5NzUsIm5iZiI6MTczOTY1NTY3NSwicGF0aCI6Ii8yOTY3MjIxMi8zMTczNDcyMTktYjFjYjBmZjItZTg1OS00YzdmLWI5YmQtMDZlY2QwMDdkMTMyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDIxNDExNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ5ZDY5YjlkZWVjMzY2NzhkNTQ0OTQyODZjNmJjODIxNmFlYTQ2ZjYwOGIwODA4NjYwZWI5ZTc2ZjkwMzQ4NzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.3pijCeBaWgQemqR-JqkyNvO0AFYQvyG7PTehfXX-c_Q)