Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add linter, update pr template, variety of cleanups #47

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

smsunarto
Copy link
Member

Closes: #XXX

What is the purpose of the change

Add a description of the overall background and high-level changes that this PR introduces

Example (remove this)

  • The metadata is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • Daemons retrieve the RPC data from the blob cache

Testing and Verifying

Please pick one of the following options

This change is a trivial rework/code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Copy link

graphite-app bot commented Mar 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “graphite/merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link

coderabbitai bot commented Mar 17, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@smsunarto smsunarto marked this pull request as ready for review March 17, 2024 21:42
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @smsunarto and the rest of your teammates on Graphite Graphite

@smsunarto smsunarto force-pushed the scott/03-17-ci-add-linter branch 4 times, most recently from a8d6258 to 0de753d Compare March 17, 2024 23:41
@smsunarto smsunarto changed the title ci: add linter ci: add linter, update pr template, variety of cleanups Mar 17, 2024
@smsunarto smsunarto force-pushed the scott/03-17-ci-add-linter branch from 0de753d to c302a50 Compare March 17, 2024 23:44
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 64.83516% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 50.72%. Comparing base (f7430a0) to head (a6781d2).

Files Patch % Lines
common/teacmd/docker.go 0.00% 10 Missing ⚠️
common/teacmd/git.go 30.76% 9 Missing ⚠️
cmd/world/root/create.go 81.48% 4 Missing and 1 partial ⚠️
common/config/config.go 66.66% 4 Missing and 1 partial ⚠️
cmd/world/root/doctor.go 90.90% 1 Missing and 1 partial ⚠️
cmd/world/root/version.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   48.73%   50.72%   +1.99%     
==========================================
  Files           8        8              
  Lines         515      412     -103     
==========================================
- Hits          251      209      -42     
+ Misses        241      179      -62     
- Partials       23       24       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smsunarto smsunarto force-pushed the scott/03-17-ci-add-linter branch from c302a50 to a6781d2 Compare March 17, 2024 23:52
@smsunarto smsunarto merged commit 9ae350c into main Mar 17, 2024
9 checks passed
@smsunarto smsunarto deleted the scott/03-17-ci-add-linter branch March 17, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant