Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub issue and PR templates #1

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Add GitHub issue and PR templates #1

merged 1 commit into from
Sep 12, 2018

Conversation

RobertWSaunders
Copy link
Contributor

I figured because this is going to be an open source project it would be nice for you to have a template for issues and pull request descriptions for people to follow.

Let me know if you don't and I'll make changes!

marianoelia
marianoelia requested changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@marianoelia marianoelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work. Couple changes

.github/PULL_REQUEST_TEMPLATE.md Outdated
## Pull Request Checklist:

- [ ] My submission passes all tests.
- [ ] I have lint my code locally prior to submission.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint not used in this project

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I'll change this!

.github/PULL_REQUEST_TEMPLATE.md Outdated

- [ ] My submission passes all tests.
- [ ] I have lint my code locally prior to submission.
- [ ] I have written new tests for my core changes (where applicable).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests used.

.github/PULL_REQUEST_TEMPLATE.md Outdated

## Pull Request Checklist:

- [ ] My submission passes all tests.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests used

.github/ISSUE_TEMPLATE.md Outdated
## Specifications

- Version:
- Platform:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform unnecessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, maybe we'll need in this in the future though, I'll get rid of it for now!

@RobertWSaunders RobertWSaunders force-pushed the feature/add-github-templates branch from c99cc5b to 830bd17 Compare September 12, 2018 01:11
@RobertWSaunders RobertWSaunders force-pushed the feature/add-github-templates branch from 830bd17 to 429a5b6 Compare September 12, 2018 01:13
@RobertWSaunders
Copy link
Contributor Author

Updated!

marianoelia
marianoelia approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@marianoelia marianoelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@marianoelia marianoelia merged commit fe4de3f into ArgonPrototypes:master Sep 12, 2018
@RobertWSaunders RobertWSaunders deleted the feature/add-github-templates branch September 12, 2018 01:16
@RobertWSaunders
Copy link
Contributor Author

I saw this really cool thing in the https://github.com/gatsbyjs/gatsby repo. If you try to create an issue there it first asks you if you want to file a bug, feature or have a general question. I noticed their .github folder has nested files, you might want to expand upon this change by adding that. I filed this issue there and thought it was cool, adding to all of my projects.

@marianoelia
Copy link
Contributor

Thanks I'll try it out

@marianoelia
Copy link
Contributor

Checker out now

@RobertWSaunders
Copy link
Contributor Author

RobertWSaunders commented Sep 13, 2018 •
edited
Loading

Nice, you should have made a PR though! Also I noticed you committed your .DS_STORE files, I'd add a .gitignore for those suckers. I made a similar PR to add to QHacks here https://github.com/qhacks/qhacks-website/pull/95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marianoelia marianoelia marianoelia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertWSaunders @marianoelia