Common: fix infinite recursion #6118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I dont understand where the recursion is without this PR that makes a lot of seemingly unrelated changes to add items to blimp |
|
Recusion comes from the hidden toc on makefly rtf pages, there are two that are referencing each other. |
Hwurzburg
requested changes
Jul 19, 2024
common/source/docs/common-rtf.rst
Outdated
| @@ -64,9 +64,11 @@ VTOL/QuadPlanes from Partners | |||
| * `FlyDragonDroneTech - FDG30 <https://www.droneassemble.com/product/vtol-uav-6-hours-endurance-with-1kg-payload-for-survey-serveillance/>`__ | |||
| * `FlyDragonDroneTech - FDG50F <https://www.droneassemble.com/product/hybrid-vtol-uav-7-hours-endurance-with-10kgs-payload/>`__ | |||
| * :ref:`Holybro Swan-K1 <common-Swan-K1>` | |||
| * :ref:`MakeFLyEasy - Fighter Hand Throw <common-makeflyeasy-fighter-hand-throw>` | |||
| * :ref:`MakeFLyEasy - Fighter VTOL <common-makeflyeasy-fighter-vtol>` | |||
| * `MakeFLyEasy - Freeman 2300 <https://www.aliexpress.com/item/10000223137957.html?spm=a2g0o.store_home.productList_1076398524.pic_3>`__ | |||
| * `MakeFLyEasy - Freeman 2100 <https://www.aliexpress.com/item/10000223137957.html?spm=a2g0o.store_home.productList_1076398524.pic_2>`__ | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
where is this model linked now?
|
@khancyr still awaiting changes |
|
@Hwurzburg updated with corrections |
Hwurzburg
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix infinite recursion that show with newer sphinx versionx
Recusion comes from the hidden toc on makefly rtf pages, there are two that are referencing each other.
Removing one, then trigger a not included into doctree issue, so I move up the hidden doctree to the common rtf page. This now trigger issue with missing include for blimp, thus the massive update on blimp