-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_HAL_ChibiOS: add hwdef files for NarinFC-H7 #29098
Conversation
Is there a description of "New Board Support" and "Wiki Need"? |
just labels for our dev team use to track PRs... |
Thank you for the explanation. |
|
There is no tool/AP_Bootloader/build_types.txt file in the path you were told. |
Since you are a bit confused, I created the PR for you #29124 |
@Hwurzburg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to be sure the bootloaders have this new id and squash all commits and then split using "Tools/gittools/git-subsystems-split" to sort into library commits
@Hwurzburg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The tone alarm change is extraneous, remove it. Submit a separate PR (which I don't think would be approved for changing the existing startup tone for everyone)
- you did not squash the commits and library split. There should be only the Tools:add NarinFC-H7 commit and a hwdef:add NarinFC-H7 commit. I can do this for one later this week if you wish
AP_HAL_ChibiOS: add hwdef files for NarinFC-H7
(ArduPilot/ardupilot:master <--- vololand/ardupilot:NarinFC-H7)