Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_HAL_ChibiOS: add hwdef files for NarinFC-H7 #29098

Closed
wants to merge 0 commits into from

Conversation

vololand
Copy link

AP_HAL_ChibiOS: add hwdef files for NarinFC-H7
(ArduPilot/ardupilot:master <--- vololand/ardupilot:NarinFC-H7)

@vololand
Copy link
Author

Is there a description of "New Board Support" and "Wiki Need"?

@Hwurzburg
Copy link
Collaborator

just labels for our dev team use to track PRs...

@vololand
Copy link
Author

Thank you for the explanation.
Labels understood.
Where can I find a description for writing wiki?

@Hwurzburg
Copy link
Collaborator

Hwurzburg commented Jan 20, 2025

@vololand

  1. Since this is an exact clone of the CUAV X7 you will need to do the following:
    • submit a separate PR for an assignment of a board id in the Tools/AP_Bootloader/build_types.txt file for your own board id. perhaps AP_HW_NarinH7 1183 as the next available. It can be merged as soon as you post it to reserve the bd id.
    • be sure to include the CUAV copyright notice on any source code copied (hwdef.dat,etc.) per their LICENSE (https://github.com/ArduPilot/Schematics/blob/master/CUAV/LICENSE)
  2. You will need to create a bootloader for this PR.
  3. For the wiki, I use the readme file included here to create a wiki page
    Once the first two items above are done , myself and others will review (I know I will ask for more details on the readme in order for me to ba able eventually create the wiki page) and once you have prototypes and have tested them, we will submit to the dev team for final review and merge into the database.

@vololand
Copy link
Author

@vololand

  1. Since this is an exact clone of the CUAV X7 you will need to do the following:

    • submit a separate PR for an assignment of a board id in the Tools/AP_Bootloader/build_types.txt file for your own board id. perhaps AP_HW_NarinH7 1183 as the next available. It can be merged as soon as you post it to reserve the bd id.
    • be sure to include the CUAV copyright notice on any source code copied (hwdef.dat,etc.) per their LICENSE (https://github.com/ArduPilot/Schematics/blob/master/CUAV/LICENSE)
  2. You will need to create a bootloader for this PR.

  3. For the wiki, I use the readme file included here to create a wiki page
    Once the first two items above are done , myself and others will review (I know I will ask for more details on the readme in order for me to ba able eventually create the wiki page) and once you have prototypes and have tested them, we will submit to the dev team for final review and merge into the database.

@Hwurzburg

There is no tool/AP_Bootloader/build_types.txt file in the path you were told.
There is a tool/AP_Bootloader/board_types.txt file in the path you told me, do you want me to write AP_HW_NarinH7 1183 here and create PR?

@Hwurzburg
Copy link
Collaborator

Hwurzburg commented Jan 21, 2025

Since you are a bit confused, I created the PR for you #29124
use AP_HW_NarinH7 for the APJ_BOARD_ID instead of a number in both hwdefs....create a bootloader .bin with this number and include it in Tools/bootloaders folder and commit in this PR

@vololand
Copy link
Author

Since you are a bit confused, I created the PR for you #29124 use AP_HW_NarinH7 for the APJ_BOARD_ID instead of a number in both hwdefs....create a bootloader .bin with this number and include it in Tools/bootloaders folder and commit in this PR

@Hwurzburg
Thank you.
Renamed from AP_HW_NarinH7 to AP_HW_NarinFC-H7.

Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to be sure the bootloaders have this new id and squash all commits and then split using "Tools/gittools/git-subsystems-split" to sort into library commits

libraries/AP_HAL_ChibiOS/hwdef/NarinFC-H7/hwdef-bl.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/NarinFC-H7/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/NarinFC-H7/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/NarinFC-H7/hwdef-bl.dat Outdated Show resolved Hide resolved
@vololand
Copy link
Author

vololand commented Feb 4, 2025

you need to be sure the bootloaders have this new id and squash all commits and then split using "Tools/gittools/git-subsystems-split" to sort into library commits

@Hwurzburg
I worked on it as you commented.
Please check.

@vololand vololand requested a review from Hwurzburg February 4, 2025 08:32
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The tone alarm change is extraneous, remove it. Submit a separate PR (which I don't think would be approved for changing the existing startup tone for everyone)
  2. you did not squash the commits and library split. There should be only the Tools:add NarinFC-H7 commit and a hwdef:add NarinFC-H7 commit. I can do this for one later this week if you wish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants