Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chat: push to record #1435

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

adityaomar3
Copy link
Contributor

This PR adds a push to record feature i.e. it will record the audio on mouse left key press down and stop the recording on key release.

@adityaomar3 adityaomar3 force-pushed the rec_button_enhancements branch from e330fea to e88196b Compare August 13, 2024 06:58
@adityaomar3 adityaomar3 force-pushed the rec_button_enhancements branch from e88196b to b90a2eb Compare August 14, 2024 18:56
@adityaomar3 adityaomar3 force-pushed the rec_button_enhancements branch 2 times, most recently from 231d627 to 9d07612 Compare August 15, 2024 20:52
@adityaomar3 adityaomar3 requested a review from rmackay9 August 19, 2024 19:03
@rmackay9
Copy link
Contributor

I've tested this and it works great!

One thing that is really impressive is how quick OpenAI can convert the audio to text. The response is nearly instantaneous

Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've asked for a couple of non-functional changes but after that we can merge it, thanks!

@adityaomar3 adityaomar3 force-pushed the rec_button_enhancements branch from 9d07612 to 151d18c Compare August 20, 2024 06:04
Co-authored-by: Randy Mackay <[email protected]>
@adityaomar3 adityaomar3 force-pushed the rec_button_enhancements branch from 151d18c to d9ee4d9 Compare August 20, 2024 06:04
Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@peterbarker peterbarker merged commit 59ebf54 into ArduPilot:master Aug 20, 2024
2 checks passed
@adityaomar3 adityaomar3 deleted the rec_button_enhancements branch August 28, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants