Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat: added password input field for api_key #1345

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

adityaomar3
Copy link
Contributor

Before input key field for api key was exposed
key_input_field_before

After changes input key field for api key

key input field after

@adityaomar3 adityaomar3 changed the title Added password input field for api_key input Added password input field for api_key Mar 25, 2024
@rmackay9
Copy link
Contributor

Hi @adityaomar3,

Thanks very much for this. It's a small thing but I wonder if you could appeand, "chat: " onto the front of the commit title? It's not big deal but if you look at our commit list you'll see we normally append the subsystem name or directory name to each commit to make it more clear what it affects. To be clear, I mean the commit title not the PR title.

This is a habit the AP devs have gotten into especially on the flight code side because it makes backporting to earlier versions easier. It's not really very important for MAVProxy but we do it anyway. Txs!

After that change I'll merge.

@rmackay9 rmackay9 changed the title Added password input field for api_key Chat: added password input field for api_key Mar 26, 2024
@rmackay9
Copy link
Contributor

I've marked this for the EU dev call, that's just so that we don't forget to merge it.

@adityaomar3 adityaomar3 force-pushed the security_key_disp branch 2 times, most recently from 9545ce9 to 927d01e Compare March 26, 2024 22:17
@rmackay9
Copy link
Contributor

Hi @adityaomar3,

By the way, is there any change in behaviour if Enter is pressed instead of pressing the "Set" button?

I forgot to bring this up on the EUDevCall but I'll ping some of the other devs in the morning and we will merge it then.

@adityaomar3
Copy link
Contributor Author

Hi @adityaomar3,

By the way, is there any change in behaviour if Enter is pressed instead of pressing the "Set" button?

I forgot to bring this up on the EUDevCall but I'll ping some of the other devs in the morning and we will merge it then.

Thanks for the review, I checked, it actually broke the enter key feature.

@adityaomar3
Copy link
Contributor Author

A small change was required, now it is working absolutely fine.

@rmackay9 rmackay9 merged commit 0f1e9e6 into ArduPilot:master Mar 27, 2024
2 checks passed
@rmackay9
Copy link
Contributor

Merged, thanks!

@adityaomar3 adityaomar3 deleted the security_key_disp branch July 10, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants