Merge pull request #430 from Appelsiini1/bug-421

Prevent navigation to main menu if theres an error in assignment input
Appelsiini1 · Jan 10, 2025 · b77f446 · b77f446
2 parents c874fac + d6007d4
commit b77f446
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/mainHelpers/fileOperations.ts b/src/mainHelpers/fileOperations.ts
@@ -503,9 +503,9 @@ async function _handleAddOrUpdateAssignmentFS(
     if (!oldAssignment) {
       // if saving new assignment, throw error if
       // identically named one exists
-      if (await assignmentExistsDB(assignment?.title, coursePath)) {
-        throw new Error("ui_assignment_error_duplicate_title");
-      }
+      // if (await assignmentExistsDB(assignment?.title, coursePath)) {
+      //   throw new Error("ui_assignment_error_duplicate_title");
+      // }
 
       _createAssignmentFolderFS(assignment, assignmentDataPath, assignmentHash);
       hashFolderPath = path.join(assignmentDataPath, assignmentHash);

diff --git a/src/routes/AssignmentInput.tsx b/src/routes/AssignmentInput.tsx
@@ -167,6 +167,10 @@ export default function AssignmentInput() {
     if (assignment.level === null && activeCourse?.levels !== null) {
       assignmentToSave.level = 0;
     }
+    if (!assignment.title) {
+      handleSnackbar({ error: parseUICode("ui_add_assignment_title") });
+      return;
+    }
 
     if (checkSpecial(assignment.title)) {
       handleSnackbar({ error: parseUICode("error_special_in_title") });
@@ -193,7 +197,7 @@ export default function AssignmentInput() {
         snackbarSeverity = "error";
       }
       handleSnackbar({ [snackbarSeverity]: parseUICode(snackbarText) });
-      navigate(-1);
+      if (snackbarSeverity !== "error") navigate(-1);
     }
   }