Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: creating document from slash menu leaves text behind #980

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Dec 3, 2024

closes AppFlowy-IO/AppFlowy#6865

Add a new parameter to enable deletion of keywords before inserting the new block.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.19%. Comparing base (bf9d7e9) to head (df825cd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/editor/selection_menu/selection_menu_widget.dart 62.50% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #980   +/-   ##
=======================================
  Coverage   72.19%   72.19%           
=======================================
  Files         318      318           
  Lines       15144    15147    +3     
=======================================
+ Hits        10933    10936    +3     
  Misses       4211     4211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit ac3b090 into AppFlowy-IO:main Dec 3, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Creating document from new block menu leaves text behind
1 participant