Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cancel block selection when tapping the editor on mobile #956

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Oct 30, 2024

Tapping on mobile to select text should cancel the block selection.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.19%. Comparing base (cca5c41) to head (452d84b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/src/editor_state.dart 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #956   +/-   ##
=======================================
  Coverage   72.19%   72.19%           
=======================================
  Files         318      318           
  Lines       15089    15093    +4     
=======================================
+ Hits        10893    10897    +4     
  Misses       4196     4196           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 5756c94 into AppFlowy-IO:main Oct 30, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant