Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: highlight search match not scrolling document to reveal said match #954

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

richardshiue
Copy link
Contributor

@richardshiue richardshiue commented Oct 29, 2024

I think some logic got lost during the transition from v2 to v3

no tests yet, need review

regression on appflowy main repo: entering text into the find text field causes title to get focus if it's empty

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.23%. Comparing base (46e00fc) to head (cdf5f26).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...onent/service/scroll/editor_scroll_controller.dart 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #954      +/-   ##
==========================================
+ Coverage   72.08%   72.23%   +0.15%     
==========================================
  Files         318      318              
  Lines       15073    15093      +20     
==========================================
+ Hits        10865    10903      +38     
+ Misses       4208     4190      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 4081fb7 into AppFlowy-IO:main Oct 30, 2024
7 checks passed
@richardshiue richardshiue deleted the fix/find-next branch October 30, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants