Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: links starting with 0 index lose href attribute after formating #947

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Oct 28, 2024

Example:

Formatting the link AppFlowy to AppFlowy.IO loses the href attribute if AppFlowy is at the beginning of the text.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.08%. Comparing base (e7d9560) to head (6582681).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #947      +/-   ##
==========================================
+ Coverage   72.07%   72.08%   +0.01%     
==========================================
  Files         318      318              
  Lines       15074    15073       -1     
==========================================
+ Hits        10864    10865       +1     
+ Misses       4210     4208       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 46e00fc into AppFlowy-IO:main Oct 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant