Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: listen on delete_backward changes #898

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Sep 25, 2024

In some cases, the onDelete command doesn't trigger as expected, but at that time, Flutter will call performSelector instead.

@LucasXu0 LucasXu0 force-pushed the apply_delete_backward_changes branch 2 times, most recently from b845b2a to ddb9df1 Compare September 25, 2024 06:48
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 72.30%. Comparing base (8582191) to head (a9b6743).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...component/service/ime/non_delta_input_service.dart 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
- Coverage   72.38%   72.30%   -0.09%     
==========================================
  Files         317      317              
  Lines       14802    14822      +20     
==========================================
+ Hits        10715    10717       +2     
- Misses       4087     4105      +18     
Flag Coverage Δ
72.30% <10.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 force-pushed the apply_delete_backward_changes branch from ddb9df1 to a9b6743 Compare September 25, 2024 07:49
@LucasXu0 LucasXu0 merged commit 737681d into AppFlowy-IO:main Sep 25, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant