Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unsupported platform error on web #881

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

kkundi
Copy link
Contributor

@kkundi kkundi commented Sep 9, 2024

Solves:
#873
#880

Modification of isIOS and isMacOS verification code execution on the web

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2024

CLA assistant check
All committers have signed the CLA.

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Sep 9, 2024

@kkundi Thank for the contribution! Please sign the CLA and resolve the conflicts.

@kkundi
Copy link
Contributor Author

kkundi commented Sep 9, 2024

@LucasXu0
I resolved the conflicts and signed CLA
Thank you!

@LucasXu0 LucasXu0 changed the title Fix/unsupported plaforms fix: unsupported platform error on web Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.49%. Comparing base (2110fde) to head (265e930).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #881   +/-   ##
=======================================
  Coverage   72.49%   72.49%           
=======================================
  Files         316      316           
  Lines       14766    14769    +3     
=======================================
+ Hits        10704    10707    +3     
  Misses       4062     4062           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 96ac065 into AppFlowy-IO:main Sep 9, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants