Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: command improvement #825

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Conversation

Xazin
Copy link
Contributor

@Xazin Xazin commented Jun 18, 2024

  • Enables clearing a command
  • Makes table commands public so we can consume then to eg. localize by the command.key

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.85%. Comparing base (b5da6e4) to head (e85c831).

Files Patch % Lines
...nent/service/shortcuts/command_shortcut_event.dart 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #825      +/-   ##
==========================================
- Coverage   74.88%   74.85%   -0.03%     
==========================================
  Files         301      301              
  Lines       14204    14204              
==========================================
- Hits        10636    10633       -3     
- Misses       3568     3571       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xazin Xazin merged commit 98a49ad into AppFlowy-IO:main Jun 18, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant