-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect cursor movement behaviour #751
Conversation
@Jei-sKappa Thanks for contributing. Please format the code. |
@LucasXu0 Thanks for your reply! Based on the response of GitHub Action it seems like the problem is in the commit message and not in the code. Am I right? |
Except for the commit message, you need to format the Dart code too. Please click on the CI and check the error. |
d7aac94
to
1c1c031
Compare
Previously the `moveVertical` function only moved the cursor 'node to node' without thaking into consideration multiline nodes or some portion of a line with different fontSize (ex: a paragraph with size 16 but with a bolded word with size 32). This was caused by the PR AppFlowy-IO#657 that closes AppFlowy-IO#656 and AppFlowy-IO#589.
1c1c031
to
7479f8c
Compare
@LucasXu0 Sorry for the late response. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
==========================================
- Coverage 75.29% 74.86% -0.44%
==========================================
Files 300 300
Lines 14011 14178 +167
==========================================
+ Hits 10550 10614 +64
- Misses 3461 3564 +103 ☔ View full report in Codecov by Sentry. |
You don't have to worry about the commitlint failing, it's not important 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to introduce some more tests so we can stop a regression from occurring.
We can add tests in a new PR, I will open a new issue once @LucasXu0 has taken a look at this PR.
fixes #745
Previously the
moveVertical
function only moved the cursor 'node to node' without taking into consideration multiline nodes or some portion of a line with different fontSize (ex: a paragraph with size 16 but with a bolded word with size 32). This was caused by the PR #657 that closes #656 and #589.