fix: Slash command menu bad positioning in Web Version #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dagyu
changed the title
dagyu
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #709 +/- ##
=======================================
Coverage 75.54% 75.54%
=======================================
Files 297 297
Lines 13707 13707
=======================================
Hits 10355 10355
Misses 3352 3352 ☔ View full report in Codecov by Sentry. |
|
@dagyu Thanks for your contribution. LGTM. |
q200892907
added a commit
to q200892907/appflowy-editor
that referenced
this pull request
Feb 19, 2024
* main: chore: upgrade flutter version to 3.19.0 (AppFlowy-IO#719) fix: the positioning of the slash command menu in the web version (AppFlowy-IO#709) fix: unable to export image block in markdown format (AppFlowy-IO#713) feat: debounce on word count service (AppFlowy-IO#711) feat: on demand word count without listening (AppFlowy-IO#710) feat: support selection counters (AppFlowy-IO#706) feat: word counter service (AppFlowy-IO#705) chore: bump version 2.3.2 chore: update Chinese i18n (AppFlowy-IO#698) fix: fix checkbox not work as expected in html module. (AppFlowy-IO#700) chore: revert ime changes (AppFlowy-IO#701)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
While developing with AppFlowy editor, I encountered the following bug in the web version. I have integrated the AppFlowy editor into my app as shown in the image. On the left side, the editor is positioned between a sidebar and a header. This placement causes a displacement of the command menu. The slippage occurs because the menu is inserted relative to its container, rather than being positioned absolutely within the web page.
Expected Behavior:
The command menu should be positioned correctly without any slippage, even when the editor is placed between a sidebar and a header.
Fix:
To resolve this issue, I modified Overlay.of(context) to Overlay.of(context, rootOverlay: true). Additionally, this fix also addresses issue #545.
Please review and consider implementing this fix in the next release. Let me know if you need any further clarification or information. Thank you!