Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix checkbox not work as expected in html module. #700

Merged
merged 9 commits into from
Feb 1, 2024
Merged

fix: fix checkbox not work as expected in html module. #700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e2a68c9
add support for breakline
penkzhou Jan 25, 2024
f93b91d
add test for br tag parse
penkzhou Jan 25, 2024
46600e9
Merge branch 'AppFlowy-IO:main' into main
penkzhou Jan 25, 2024
d7d573d
fix test failure case.
penkzhou Jan 26, 2024
920d2ea
Merge branch 'AppFlowy-IO:main' into main
penkzhou Jan 27, 2024
f7563e7
feat: add html support
penkzhou Jan 29, 2024
85835df
Merge branch 'main' of https://github.com/penkzhou/appflowy-editor
penkzhou Jan 29, 2024
f338547
Merge branch 'AppFlowy-IO:main' into main
penkzhou Jan 30, 2024
7f7335a
fix: todo list(checkbox) not work as expected
penkzhou Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/src/plugins/html/encoder/parser/todo_list_node_parser.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,12 @@ class HTMLTodoListNodeParser extends HTMLNodeParser {
}) {
final delta = node.delta ?? Delta();
final domNodes = deltaHTMLEncoder.convert(delta);

final elementNode = dom.Element.html('<input type="checkbox" />');
elementNode.attributes['checked'] =
node.attributes[TodoListBlockKeys.checked].toString();
domNodes.add(elementNode);
if (node.attributes[TodoListBlockKeys.checked] as bool? ?? false) {
elementNode.attributes['checked'] = '';
}
domNodes.insert(0, elementNode);
domNodes.addAll(
processChildrenNodes(node.children, encodeParsers: encodeParsers),
);
Expand Down
4 changes: 2 additions & 2 deletions test/plugins/html/encoder/parser/text_node_parser_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,12 @@ void main() async {
expect(
const HTMLTodoListNodeParser()
.transformNodeToHTMLString(checkedNode, encodeParsers: parser),
'<div>Welcome to AppFlowy<input type="checkbox" checked="true"></div>',
'<div><input type="checkbox" checked="">Welcome to AppFlowy</div>',
);
expect(
const HTMLTodoListNodeParser()
.transformNodeToHTMLString(uncheckedNode, encodeParsers: parser),
'<div>Welcome to AppFlowy<input type="checkbox" checked="false"></div>',
'<div><input type="checkbox">Welcome to AppFlowy</div>',
);
});

Expand Down
Loading