-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate commands #687
Merged
Merged
Translate commands #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpenna
commented
Jan 24, 2024
@@ -11,10 +11,11 @@ class CommandShortcutEvent { | |||
required this.key, | |||
required this.command, | |||
required this.handler, | |||
required String Function()? getDescription, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value is optional for cases where we don't want to allow the user to override, for example, when pasting a link and converting that to a link.
4 tasks
@jpenna I have merged your previous PR already. Please resolve the conflicts. |
q200892907
added a commit
to q200892907/appflowy-editor
that referenced
this pull request
Jan 31, 2024
* main: chore: bump version 2.3.1 (AppFlowy-IO#697) feat: add contentInsertionConfiguration to editor and text input service (AppFlowy-IO#691) fix: add support for breakline and divider (AppFlowy-IO#690) chore: translate commands (AppFlowy-IO#687)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge this one first #680
This PR adds translations for all commands.