Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate commands #687

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Translate commands #687

merged 2 commits into from
Jan 30, 2024

Conversation

jpenna
Copy link
Contributor

@jpenna jpenna commented Jan 24, 2024

Merge this one first #680


This PR adds translations for all commands.

@jpenna jpenna marked this pull request as draft January 24, 2024 13:21
@@ -11,10 +11,11 @@ class CommandShortcutEvent {
required this.key,
required this.command,
required this.handler,
required String Function()? getDescription,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value is optional for cases where we don't want to allow the user to override, for example, when pasting a link and converting that to a link.

@LucasXu0
Copy link
Collaborator

@jpenna I have merged your previous PR already. Please resolve the conflicts.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 231 lines in your changes are missing coverage. Please review.

Comparison is base (7d8147c) 76.46% compared to head (6afa6b8) 75.45%.

Files Patch % Lines
lib/src/l10n/l10n.dart 0.00% 164 Missing ⚠️
...omponent/table_block_component/table_commands.dart 0.00% 11 Missing ⚠️
.../service/shortcuts/command/arrow_left_command.dart 0.00% 6 Missing ⚠️
...service/shortcuts/command/arrow_right_command.dart 0.00% 6 Missing ⚠️
...t/service/shortcuts/command/markdown_commands.dart 0.00% 5 Missing ⚠️
.../service/shortcuts/command/arrow_down_command.dart 0.00% 4 Missing ⚠️
...nt/service/shortcuts/command/arrow_up_command.dart 0.00% 4 Missing ⚠️
...nent/service/shortcuts/command_shortcut_event.dart 0.00% 3 Missing ⚠️
...ervice/shortcuts/command/find_replace_command.dart 0.00% 2 Missing ⚠️
...onent/service/shortcuts/command/paste_command.dart 0.00% 2 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #687      +/-   ##
==========================================
- Coverage   76.46%   75.45%   -1.01%     
==========================================
  Files         295      295              
  Lines       13309    13614     +305     
==========================================
+ Hits        10177    10273      +96     
- Misses       3132     3341     +209     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpenna jpenna marked this pull request as ready for review January 26, 2024 20:30
@LucasXu0 LucasXu0 merged commit 84e5adc into AppFlowy-IO:main Jan 30, 2024
9 of 11 checks passed
@jpenna jpenna deleted the a4276-trans2 branch January 30, 2024 14:42
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Jan 31, 2024
* main:
  chore: bump version 2.3.1 (AppFlowy-IO#697)
  feat: add contentInsertionConfiguration to editor and text input service (AppFlowy-IO#691)
  fix: add support for breakline and divider (AppFlowy-IO#690)
  chore: translate commands (AppFlowy-IO#687)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants