Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: toggledStyle notifier #562

Merged
merged 1 commit into from
Oct 30, 2023
Merged

feat: toggledStyle notifier #562

merged 1 commit into from
Oct 30, 2023

Conversation

Xazin
Copy link
Contributor

@Xazin Xazin commented Oct 29, 2023

Closes: #561

@Xazin
Copy link
Contributor Author

Xazin commented Oct 29, 2023

Use-case preview:

Screen.Recording.2023-10-29.at.17.39.41.mov

@codecov
Copy link

codecov bot commented Oct 29, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a573847) 80.35% compared to head (657947a) 80.36%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #562   +/-   ##
=======================================
  Coverage   80.35%   80.36%           
=======================================
  Files         285      285           
  Lines       12173    12178    +5     
=======================================
+ Hits         9782     9787    +5     
  Misses       2391     2391
Files Coverage Δ
lib/src/editor/command/text_commands.dart 87.96% <100.00%> (ø)
lib/src/editor_state.dart 85.10% <100.00%> (+0.40%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 2dacd74 into AppFlowy-IO:main Oct 30, 2023
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Oct 30, 2023
@q200892907
Merge branch 'main' into feat-zhiya
8c01fd5 
* main:
  fix: on ui event reset selection type (AppFlowy-IO#555)
  feat: power checkbox shortcut (AppFlowy-IO#553)
  feat: toggledStyle notifier (AppFlowy-IO#562)
  fix: do not select all if selection is null (AppFlowy-IO#563)
  fix: applied corner radius to block selection (AppFlowy-IO#557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasXu0 LucasXu0 LucasXu0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] Listen to updates for toggledStyle in EditorState
2 participants
@Xazin @LucasXu0