Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed unresponsive behaviour of context menu items #349

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

Mukund-Tandon
Copy link
Contributor

@Mukund-Tandon Mukund-Tandon commented Jul 29, 2023

fixes: AppFlowy-IO/AppFlowy#3077

Before-

Screen.Recording.2023-07-31.at.5.16.17.PM.mov

After-

Screen.Recording.2023-07-31.at.5.16.58.PM.mov

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #349 (ea8faf6) into main (b729aa9) will increase coverage by 0.75%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
+ Coverage   75.21%   75.96%   +0.75%     
==========================================
  Files         247      247              
  Lines        9843     9846       +3     
==========================================
+ Hits         7403     7480      +77     
+ Misses       2440     2366      -74     
Files Changed Coverage Δ
...rvice/context_menu/built_in_context_menu_item.dart 100.00% <100.00%> (+100.00%) ⬆️

... and 4 files with indirect coverage changes

@Mukund-Tandon Mukund-Tandon marked this pull request as ready for review July 31, 2023 11:50
@LucasXu0 LucasXu0 merged commit c3f62b3 into AppFlowy-IO:main Aug 2, 2023
@LucasXu0 LucasXu0 mentioned this pull request Aug 8, 2023
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Aug 8, 2023
* main:
  chore: add codecov token (AppFlowy-IO#352)
  feat: paste plaintext shortcut (AppFlowy-IO#338)
  fix: fixed unresponsive behaviour of context menu items (AppFlowy-IO#349)
  fix: fixed the issue of code block not being exported in markdown (AppFlowy-IO#347)
  chore: format code (AppFlowy-IO#345)
  feat: expose context in nodeBuilder (AppFlowy-IO#350)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Context Menu is not working
2 participants