Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support scroll without animation #343

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Jul 25, 2023

  • support scroll to position without animation.
x.mp4

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #343 (cce8745) into main (3e99f19) will decrease coverage by 1.01%.
The diff coverage is 26.02%.

@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
- Coverage   76.21%   75.21%   -1.01%     
==========================================
  Files         246      247       +1     
  Lines        9649     9843     +194     
==========================================
+ Hits         7354     7403      +49     
- Misses       2295     2440     +145     
Files Changed Coverage Δ
...mponent/service/scroll/desktop_scroll_service.dart 79.48% <ø> (ø)
...omponent/service/scroll/mobile_scroll_service.dart 0.00% <ø> (ø)
lib/src/flutter/scrollable_helpers.dart 25.53% <25.53%> (ø)
...ditor_component/service/scroll_service_widget.dart 76.25% <28.57%> (-4.84%) ⬇️
...editor_component/service/scroll/auto_scroller.dart 35.71% <100.00%> (ø)

@LucasXu0 LucasXu0 closed this Jul 25, 2023
@LucasXu0 LucasXu0 reopened this Jul 25, 2023
@LucasXu0 LucasXu0 merged commit b729aa9 into AppFlowy-IO:main Jul 25, 2023
@LucasXu0 LucasXu0 mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant