fix: improve performance on editor overlays #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
richardshiue
force-pushed
the
fix-overlay-jank
branch
from
f68eef3 to
ffb103f
Compare
LucasXu0
approved these changes
Jul 25, 2023
Codecov Report
@@ Coverage Diff @@
## main #336 +/- ##
==========================================
+ Coverage 76.02% 76.03% +0.01%
==========================================
Files 247 246 -1
Lines 9725 9717 -8
==========================================
- Hits 7393 7388 -5
+ Misses 2332 2329 -3
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes performance issues wherever there is an overlay involved. Sorry for the bad frame rate, but I hope you can actually see a difference.
Ref: github.com/AppFlowy-IO/AppFlowy/issues/2659
before-after.mp4