Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove action container space in mobile #135

Merged

Conversation

hyj1204
Copy link
Contributor

@hyj1204 hyj1204 commented May 24, 2023

I removed the action container when there is no action(in mobile). The previous code still occupy a space when showActions is false

image

@hyj1204 hyj1204 requested a review from LucasXu0 May 24, 2023 15:54
@hyj1204 hyj1204 self-assigned this May 24, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #135 (4f38d1f) into main (b3d4529) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
- Coverage   60.43%   60.42%   -0.02%     
==========================================
  Files         208      208              
  Lines        9320     9321       +1     
==========================================
- Hits         5633     5632       -1     
- Misses       3687     3689       +2     
Impacted Files Coverage Δ
...onent/service/renderer/block_component_action.dart 14.28% <33.33%> (-5.72%) ⬇️

@LucasXu0 LucasXu0 merged commit 5f4e9ef into AppFlowy-IO:main May 27, 2023
LucasXu0 added a commit that referenced this pull request May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants