Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(appflowy_flutter): update to Flutter 3.7.5 #2000

Merged
merged 16 commits into from
Apr 4, 2023

Conversation

hyj1204
Copy link
Contributor

@hyj1204 hyj1204 commented Mar 15, 2023

  • run flutter pub upgrade --major-versions and update dependencies version
  • Due to color is deprecated in flutter_svg package, update it with
colorFilter:
           color != null ? ColorFilter.mode(color!, BlendMode.srcIn) : null,
  • Delete unnecessary code, deprecated field and formatting code

This PR followed the work in #1990
Fixes #1954

@@ -0,0 +1,52 @@
name: AppFlowyEditor test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add this file back. We have moved it to the appflowy_editor repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Mar 16, 2023

@hyj1204 The integrate_test failed. The other parts look good to me. Also, some scripts need to be updated.

Screenshot 2023-03-16 at 09 48 15

@LucasXu0
Copy link
Collaborator

@hyj1204
Copy link
Contributor Author

hyj1204 commented Mar 16, 2023

@hyj1204 hyj1204 requested a review from LucasXu0 March 16, 2023 05:08
@LucasXu0
Copy link
Collaborator

LGTM. Will merge it after releasing v0.1.1.

@LucasXu0 LucasXu0 force-pushed the flutter_3_7_5 branch 4 times, most recently from ecf8574 to 33fc0c1 Compare March 24, 2023 08:18
@annieappflowy annieappflowy added the infra engineering tasks that are not related to UX/UI features label Mar 27, 2023
@appflowy appflowy merged commit 231fd38 into AppFlowy-IO:main Apr 4, 2023
@hyj1204 hyj1204 deleted the flutter_3_7_5 branch April 4, 2023 14:20
LucasXu0 added a commit to LucasXu0/AppFlowy that referenced this pull request Apr 6, 2023
* chore: upgrade appflowy_editor_plugins and flowy_infra

* feat(appflowy_flutter): upgrade dependence and delete unused import files

* fix(appflowy_flutter): fix SvgPicture upgrade issue

update color to colorFilter: apply mask color when the color is not null

* feat(appflowy_editor): updateflutter_svg version

* chore: flutter analyze

* chore: update to 3.7.5 in github action

* chore: update to 3.7.5 in github action(integration test)

* chore: update appflowy_editor to 0.1.2

* chore: delete appflowy_editor_test.yml under appflowy

* chore: update the flutter version in github action

* docs: update flutter badge image

* chore: update flutter version in scripts

* chore: update appflowy editor to the latest release

* chore: fix flutter analyze

* chore: update integration_test.yml

---------

Co-authored-by: Lucas.Xu <[email protected]>
Co-authored-by: Nathan.fooo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra engineering tasks that are not related to UX/UI features
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FR] Upgrade to Flutter 3.7.5
4 participants