Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Overrided Methods in Text Input Service #1895

Closed
wants to merge 2 commits into from

Conversation

Akshay-akkay
Copy link

For Flutter 3.7.0 (#1741)

@CLAassistant
Copy link

CLAassistant commented Feb 27, 2023

CLA assistant check
All committers have signed the CLA.

@LucasXu0
Copy link
Collaborator

Hey, @Akshay-akkay. Thanks for your contribution. We use Flutter 3.3.10 now, so the CI will complain if you override those functions introduced in Flutter 3.7.x.

@LucasXu0 LucasXu0 self-requested a review February 28, 2023 01:22
@Akshay-akkay
Copy link
Author

@LucasXu0 Thanks for the information. Should I try to update flutter version in gh workflows or there is some sort of process to be followed before upgrading flutter.

@LucasXu0
Copy link
Collaborator

Hey, @Akshay-akkay.

  1. Update the gh workflows.
  2. Update the documentation on Gitbook. https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/environment-setup

@LucasXu0 LucasXu0 marked this pull request as draft March 7, 2023 01:35
@LucasXu0 LucasXu0 closed this Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants