Preparation for publication #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I confirmed that all slow tests pass on a GPU. We will need to add links to the papers once they are published. |
nix-apollo
approved these changes
Apr 19, 2024
| pytest --durations=10 |
There was a problem hiding this comment.
Sad, but acceptable. We'll want to make sure that we manually run slow tests on gpu before merging PRs.
| @@ -295,7 +295,7 @@ def test_modular_arithmetic_build_graph( | |||
| } | |||
| ) | |||
| results = graph_build_test(config=config, atol=atol) | |||
| get_rib_acts_test(results, atol=0) # Need atol=1e-3 if float32 | |||
| get_rib_acts_test(results, atol=1e-15) # Need atol=1e-3 if float32 | |||
There was a problem hiding this comment.
not sure why these tolerances needed to be lowered. Maybe different gpu architectures or torch version? But 1e-15 is small enough I don't really care.
| @@ -185,12 +141,11 @@ def ablation_results(self, temp_object, rib_results) -> dict: | |||
|
|
|||
| return ablation_results | |||
|
|
|||
| @pytest.mark.xfail( | |||
There was a problem hiding this comment.
Seems nicer to have this marked as an xfailing test rather than just not checking all the layers that fail.
| @@ -36,6 +36,8 @@ def get_modular_arithmetic_config(*updates: dict) -> RibBuildConfig: | |||
| basis_formula: (1-0)*alpha | |||
| edge_formula: squared | |||
| n_stochastic_sources_edges: null | |||
| integration_method: gauss-legendre | |||
There was a problem hiding this comment.
This is consistent with the old default rib build config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for publication
Description
test_distributed.test_squared_edges_are_same_dist_split_over_datasetwith xfail due to unknown error. Made issue here.Motivation and Context
Various bits of cleaning and fixes required before making repo public
Does this PR introduce a breaking change?