Implement tls support for the app #6007
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frawless
reviewed
Feb 27, 2025
Comment on lines
+45
to
+50
| if (truststore.isValid() && truststorePassword.isValid()) { | ||
| // ===== Truststore | ||
| truststore.applySecretVolume(deployment, containerName); | ||
| addEnvVar(env, QUARKUS_TLS_TRUST_STORE_P12_PATH, truststore.getSecretVolumeKeyPath()); | ||
| truststorePassword.applySecretEnvVar(env, QUARKUS_TLS_TRUST_STORE_P12_PASSWORD); | ||
| } |
There was a problem hiding this comment.
what if I will use just PEM cert as truststore? Like
kind: ApicurioRegistry3
apiVersion: registry.apicur.io/v1
metadata:
name: schema-registry
spec:
app:
storage:
type: "kafkasql"
kafkasql:
bootstrapServers: anubis-kafka-bootstrap.strimzi-kafka.svc:9093
tls:
truststoreSecretRef:
name: anubis-cluster-ca-cert
key: ca.crt
wouldn't it cause failure? I would more expect that keystore password will be required
There was a problem hiding this comment.
At the operator level we're supporting P12 (since it's usually a better practice than just specifying cert by cert). You will still be able to use PEM files using Quarkus own env vars.
| import java.util.Map; | ||
| import java.util.Optional; | ||
|
|
||
| import static io.apicurio.registry.operator.EnvironmentVariables.*; |
There was a problem hiding this comment.
Just a nit, but * is not much good practice form my pov (different projects, different standards) :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.