feat(operator): Support for JAVA_OPTS_APPEND when creating app deployment #5933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsenko
force-pushed
the
feat/operator-java-opts
branch
from
989f56c to
e2ec14a
Compare
jsenko
previously approved these changes
Feb 12, 2025
|
Note: Rebase onto #5971 |
jsenko
force-pushed
the
feat/operator-java-opts
branch
from
7f6b14b to
98b34bf
Compare
|
I've seen some condition-related errors as well as a problem with resource discriminators. I'll try to address this in my PR and see if it helps. Otherwise I'm not sure what causes the test failures, but it might be unrelated to this PR. |
|
yeah we should tune the default timeouts better https://github.com/Apicurio/apicurio-registry/blob/main/operator/controller/src/test/java/io/apicurio/registry/operator/it/ITBase.java#L322 because it seems one size does not fit all. Maybe we should define two different short wait and long wait options... |
|
Note: Rebase onto #5979 to see if the wf passes. |
jsenko
previously approved these changes
Feb 17, 2025
jsenko
force-pushed
the
feat/operator-java-opts
branch
from
42a32ca to
ff63e3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.