feature behind a flag

Apicurio · Feb 15, 2023 · ccb8c8c · ccb8c8c
1 parent 13fb3d8
commit ccb8c8c
Show file tree

Hide file tree

Showing 12 changed files with 38 additions and 7 deletions.
diff --git a/app/src/main/java/io/apicurio/registry/ui/beans/ConfigJsUi.java b/app/src/main/java/io/apicurio/registry/ui/beans/ConfigJsUi.java
@@ -25,6 +25,7 @@
 public class ConfigJsUi {
 
     public String contextPath;
+    public boolean codegenEnabled;
 
     /**
      * Constructor.

diff --git a/app/src/main/java/io/apicurio/registry/ui/config/UiConfigProperties.java b/app/src/main/java/io/apicurio/registry/ui/config/UiConfigProperties.java
@@ -58,6 +58,11 @@ public class UiConfigProperties {
     @Info(category = "ui", description = "UI context path", availableSince = "2.1.0.Final")
     String uiContextPath;
 
+    @Inject
+    @ConfigProperty(name = "registry.ui.config.uiCodegenEnabled", defaultValue = "false")
+    @Info(category = "ui", description = "UI codegen enabled", availableSince = "2.4.2.Final")
+    boolean uiCodegenEnabled;
+
     @Inject
     @ConfigProperty(name = "registry.ui.config.apiUrl")
     @Info(category = "ui", description = "UI APIs URL", availableSince = "1.3.0.Final")
@@ -106,6 +111,7 @@ void onConstruct() {
         log.debug("============> featureReadOnly  " + featureReadOnly);
         log.debug("============> featureSettings  " + featureSettings);
         log.debug("============> uiContextPath  " + uiContextPath);
+        log.debug("============> codegenEnabled  " + uiCodegenEnabled);
         log.debug("============> apiUrl  " + apiUrl);
     }
 
@@ -125,6 +131,14 @@ public String getUiContextPath() {
         return uiContextPath;
     }
 
+    public boolean getUiCodegenEnabled() {
+        return uiCodegenEnabled;
+    }
+
+    public String getUi() {
+        return uiContextPath;
+    }
+
     public String getApiUrl() {
         return apiUrl;
     }

diff --git a/app/src/main/java/io/apicurio/registry/ui/servlets/ConfigJsServlet.java b/app/src/main/java/io/apicurio/registry/ui/servlets/ConfigJsServlet.java
@@ -78,6 +78,7 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response)
             config.artifacts.url = this.generateApiUrl(request);
 
             config.ui.contextPath = uiConfig.getUiContextPath();
+            config.ui.codegenEnabled = uiConfig.getUiCodegenEnabled();
 
             config.features.readOnly = uiConfig.isFeatureReadOnly();
             config.features.settings = uiConfig.isFeatureSettings();

diff --git a/ui/config/config-keycloakjs-rbac.js b/ui/config/config-keycloakjs-rbac.js
@@ -4,7 +4,8 @@ var ApicurioRegistryConfig = {
     },
     ui: {
         contextPath: "/",
-        navPrefixPath: "/"
+        navPrefixPath: "/",
+        codegenEnabled: false
     },
     auth: {
         type: "keycloakjs",

diff --git a/ui/config/config-keycloakjs.js b/ui/config/config-keycloakjs.js
@@ -4,7 +4,8 @@ var ApicurioRegistryConfig = {
     },
     ui: {
         contextPath: "/",
-        navPrefixPath: "/"
+        navPrefixPath: "/",
+        codegenEnabled: false
     },
     auth: {
         type: "keycloakjs",

diff --git a/ui/config/config-none.js b/ui/config/config-none.js
@@ -4,7 +4,8 @@ var ApicurioRegistryConfig = {
     },
     ui: {
         contextPath: "/",
-        navPrefixPath: "/"
+        navPrefixPath: "/",
+        codegenEnabled: false
     },
     auth: {
         type: "none"

diff --git a/ui/config/config-oidcjs.js b/ui/config/config-oidcjs.js
@@ -4,7 +4,8 @@ var ApicurioRegistryConfig = {
     },
     ui: {
         contextPath: "/",
-        navPrefixPath: "/"
+        navPrefixPath: "/",
+        codegenEnabled: false
     },
     auth: {
         type: "oidc",

diff --git a/ui/package-lock.json b/ui/package-lock.json
diff --git a/ui/src/app/pages/artifactVersion/artifactVersion.tsx b/ui/src/app/pages/artifactVersion/artifactVersion.tsx
@@ -99,6 +99,7 @@ export class ArtifactVersionPage extends PageComponent<ArtifactVersionPageProps,
             <Tab eventKey={0} title="Overview" key="overview" tabContentId="tab-info">
                 <InfoTabContent artifact={artifact}
                                 isLatest={this.versionParam() === "latest"}
+                                codegenEnabled={Services.getConfigService().uiCodegenEnabled()}
                                 rules={this.rules()}
                                 onEnableRule={this.doEnableRule}
                                 onDisableRule={this.doDisableRule}

diff --git a/ui/src/app/pages/artifactVersion/components/tabs/info.tsx b/ui/src/app/pages/artifactVersion/components/tabs/info.tsx
@@ -53,6 +53,7 @@ import { If } from "../../../../components/common/if";
 export interface InfoTabContentProps extends PureComponentProps {
     artifact: ArtifactMetaData;
     isLatest: boolean;
+    codegenEnabled: boolean;
     rules: Rule[];
     onEnableRule: (ruleType: string) => void;
     onDisableRule: (ruleType: string) => void;
@@ -188,7 +189,7 @@ export class InfoTabContent extends PureComponent<InfoTabContentProps, InfoTabCo
                                         title="Download artifact content"
                                         onClick={this.props.onDownloadArtifact}
                                         variant="secondary"><DownloadIcon /> Download</Button>
-                                {((window as any).kiota !== undefined) ? 
+                                {((window as any).kiota !== undefined && this.props.codegenEnabled) ? 
                                 <Button id="generate-client-action"
                                         data-testid="artifact-btn-gen-client"
                                         isDisabled={this.props.artifact.type !== "OPENAPI"}

diff --git a/ui/src/services/config/config.service.ts b/ui/src/services/config/config.service.ts
@@ -41,7 +41,8 @@ const DEFAULT_CONFIG: ConfigType = {
     },
     ui: {
         contextPath: "/",
-        navPrefixPath: "/"
+        navPrefixPath: "/",
+        codegenEnabled: false
     }
 };
 
@@ -95,6 +96,13 @@ export class ConfigService implements Service {
         return this.config.ui.navPrefixPath;
     }
 
+    public uiCodegenEnabled(): boolean {
+        if (!this.config.ui || !this.config.ui.codegenEnabled) {
+            return false;
+        }
+        return this.config.ui.codegenEnabled;
+    }
+
     public features(): FeaturesConfig {
         const defaults: FeaturesConfig = {
             readOnly: false,

diff --git a/ui/src/services/config/config.type.ts b/ui/src/services/config/config.type.ts
@@ -87,6 +87,7 @@ export interface ArtifactsConfig {
 export interface UiConfig {
     contextPath?: string;
     navPrefixPath?: string;
+    codegenEnabled?: boolean;
 }
 
 export interface AuthConfig {