Skip to content

Commit

Permalink
iox-eclipse-iceoryx#1104 Update readme and release document
Browse files Browse the repository at this point in the history
Signed-off-by: Christian Eltzschig <[email protected]>
  • Loading branch information
elfenpiff committed Sep 22, 2022
1 parent 6f1bbed commit 2058ec6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion doc/website/release-notes/iceoryx-unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -484,4 +484,4 @@

Compilers like ``gcc-12>`` and `clang>14` as well as static code analysis tools like `clang-tidy`
will warn the user with a used after move warning when one accesses a moved object. Accessing
a moved `unique_ptr` is well defined and behaves like dereferencing a `nullptr`.
a moved `function` is well defined and behaves like dereferencing a `nullptr`.
6 changes: 3 additions & 3 deletions iceoryx_examples/icediscovery/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ To register the callback we call
<!--[geoffrey][iceoryx_examples/icediscovery/include/discovery_monitor.hpp][registerCallback]-->
```cpp
template <typename Callback>
bool Discovery::registerCallback(const Callback& callback)
void Discovery::registerCallback(const Callback& callback)
```

which attaches the callback to the listener.
Expand All @@ -408,7 +408,7 @@ Since the listener can only call static or free functions, we use an additional
void Discovery::invokeCallback(ServiceDiscovery*, Discovery* self)
{
// discarded discovery argument is required by the listener
self->m_callback(*self);
(*self->m_callback)(*self);
}
```
Expand All @@ -430,7 +430,7 @@ void Discovery::deregisterCallback()
{
m_listener.detachEvent(*m_discovery, iox::runtime::ServiceDiscoveryEvent::SERVICE_REGISTRY_CHANGED);
}
m_callback = nullptr;
m_callback.reset();
}
```

Expand Down

0 comments on commit 2058ec6

Please sign in to comment.