Skip to content

Commit

Permalink
Downgrade Ember from 2.12.2 to 2.11.3
Browse files Browse the repository at this point in the history
Ember Data 2.12 introduced a bug which prevents destroys and saves 
happening within the same run loop.  We had originally updated Ember to 
2.13 and then found this issue when testing repeaters which routinely 
destroy and save within the same run loop, thus exposing the problem.

Since this bug is subtle and may be present in unknown places elsewhere
in the codebase, it was determined that downgrading to 2.11.* makes the
most sense as a temporary fix until the project can eventually be updated
to the latest version of Ember Data.

We originally attempted upgrading to several NEWER version of Ember Data
(instead of downgrading), but there were many other test failures that
showed up and not enough time to fix the root causes, so this is a 
sensible temporary fix.

bug introduced = emberjs/data#4668
bug reported = emberjs/data#4993
bug fixed = emberjs/data#4994
  • Loading branch information
Alex Burkhart + Aaron Christy committed Oct 31, 2017
1 parent 3cb741e commit d598e13
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
6 changes: 5 additions & 1 deletion client/app/services/store.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,11 @@ export default DS.Store.extend({
},

allTaskClasses() {
return Object.keys(this._identityMap._map).filter((k) => {
var allModelClasses = _.map(this.typeMaps, function(typeMap){
return _.pluck(typeMap.records, 'modelName');
}).flatten().uniq();

return allModelClasses.filter((k) => {
return k.match(/-task/);
});
},
Expand Down
2 changes: 1 addition & 1 deletion client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"ember-click-outside": "^0.1.6",
"ember-composable-helpers": "^1.1.2",
"ember-concurrency": "^0.8.5",
"ember-data": "2.12.2",
"ember-data": "2.11.3",
"ember-data-factory-guy": "2.13.7",
"ember-data-filter": "1.13.0",
"ember-disable-proxy-controllers": "^1.0.1",
Expand Down
6 changes: 3 additions & 3 deletions client/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3056,9 +3056,9 @@ [email protected]:
dependencies:
ember-cli-babel "^5.0.0"

ember-data@2.12.2:
version "2.12.2"
resolved "https://registry.yarnpkg.com/ember-data/-/ember-data-2.12.2.tgz#45369001847b59e7d0ca8b183e9f57cb1f339260"
ember-data@2.11.3:
version "2.11.3"
resolved "https://registry.yarnpkg.com/ember-data/-/ember-data-2.11.3.tgz#46ba0e8411dce6dbb52cc02a29194f265b747ef9"
dependencies:
amd-name-resolver "0.0.5"
babel-plugin-feature-flags "^0.2.1"
Expand Down

0 comments on commit d598e13

Please sign in to comment.