feat(log): also report negotiations error in WARN level #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Like Anorov#70, but also for negotiation errors (e.g. user/pswd denied messages). - Increase log-level from DEBUG-->WARNING because if dest-address resolves to multiple IPs, practically that is the only place where the real failure-cause it is reported. - Correct way should have been to log from within Python's `socket.create_connection()`.
+ Utilize parent-class `Exception.args` and preserve existing API's `msg` and `socket_error` attributes as @Property definitions. + Move part of `_prepare_msg()` formatting code into refactored ProxyError classes.
|
If in the far future Python-lib accepts python/cpython#562 (http://bugs.python.org/issue29757#) gets merged, then this PR can be reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
messages).
resolves to multiple IPs, practically that is the only place where the
real failure-cause it is reported.
socket.create_connection().ProxyErrorexception that did not setargsand, among others, repr() is empty.