Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IsAutoCloseEnabled bindable property for MoveToActionCell #7

Merged

Conversation

alexmartinezm
Copy link
Contributor

Hello,

I have created a new BindableProperty in MoveToActionCell called IsAutoCloseEnabledProperty. The main goal of this property is self-explanatory. I have also added a new SamplePage to interact with this new property.

Demo

@alexmartinezm
Copy link
Contributor Author

alexmartinezm commented Nov 30, 2018

Ok. Furthermore, we could create a property called IsDestructive to achieve the MoveToAction sample behaviour (next goal).

Cheers,

@AndreiMisiukevich
Copy link
Owner

@alexmartinezm i will check it on weekend and merge
Thanks

@alexmartinezm
Copy link
Contributor Author

I added a minor change to execute ForceClose before event and command. I have added this to avoid UI changes (eg converters in the sample) after swiping the cell.

@AndreiMisiukevich
Copy link
Owner

I am going to validate PR in 1h :)

@AndreiMisiukevich AndreiMisiukevich merged commit 4fa99ad into AndreiMisiukevich:master Dec 2, 2018
@alexmartinezm alexmartinezm deleted the adding_autoclose branch December 3, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants