Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line option should have higher priority then .nodemcutool file #21

Closed
tae-jun opened this issue Dec 3, 2016 · 3 comments
Closed
Milestone

Comments

@tae-jun
Copy link

tae-jun commented Dec 3, 2016

Hi dear developers

First of all, thanks a lot for the cool tool! I use it really well. I love it!

So, my suggestion is making command line option have higher priority then options in .nodemcutool file. Which means, if I run command below:

nodemcu-tool upload -o -c src/*.lua

and if I have .nodemcutool file:

{
    "baudrate": "115200",
    "port": "/dev/cu.wchusbserial1420",
    "optimize": false,
    "compile": false,
    "keeppath": false
}

It doesn't compile or optimize sources because of optimize and compile option in .nodemcutool. But I think command line options are first!

It would be really grateful if you accept my suggestion 😄

Thanks

@AndiDittrich AndiDittrich added this to the v3.0.0 milestone Dec 3, 2016
@AndiDittrich
Copy link
Owner

Dear Jun,

thats a great idea!
because of the incomaptibility, such a modification should only take place in a major release. therefore i will project it for v3

best regards, Andi

@tae-jun
Copy link
Author

tae-jun commented Dec 3, 2016

Cool! Thanks for your prompt response 😄

I look forward to it 👍

@AndiDittrich
Copy link
Owner

implemented in v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants