refactor(ui): add RoundedButton.bright constructor #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
=======================================
Coverage ? 72.74%
=======================================
Files ? 134
Lines ? 1596
Branches ? 0
=======================================
Hits ? 1161
Misses ? 435
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
marfavi
changed the title
|
Check out #555 which would merge into this branch |
This commit reduces code duplication by creating a new constructor to the `RoundedButton` class, making it usable as a replacement for the following buttons: 1. the "Resend verification email" button 2. the button in `SplashErrorPage` Beforehand, these two buttons used tedious boilerplate by invoking the Material `ElevatedButton`; a thing the `RoundedButton` was supposed to eliminate. Additionally, I simplified some code in the files this change affected.
marfavi
changed the title
marfavi
previously approved these changes
Nov 21, 2023
marfavi
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces code duplication by creating a new constructor to the
RoundedButton class, making it usable as a replacement for the following buttons:
Beforehand, these two buttons used tedious boilerplate by invoking the Material ElevatedButton; a thing the RoundedButton was supposed to eliminate.
Additionally, files affected this change have been simplified.
closes #508
Co-authored-by: Omid Marfavi [email protected]