-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release dev/prod versions off a main branch #517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make this work also the build flow must be changed. Previously we signed the apps for prod builds, and handled it differently for the dev app. Since the condition for production branches is not valid any more, we must rewrite the build part again to handle two types of building the app
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #517 +/- ##
========================================
Coverage 73.93% 73.93%
========================================
Files 128 128
Lines 1527 1527
========================================
Hits 1129 1129
Misses 398 398
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😇
After merging this branch, the
develop
should be renamed intomain
, and theproduction
branch should be removed.A version is released by creating a release with a new appropriately-named tag.
Development versions would be released off of every new push onto the main branch.
Note: in
release-dev
/release-prod
,token
is deprecated. UseserviceCredentialsFileContent
instead