Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release dev/prod versions off a main branch #517

Merged
merged 10 commits into from
Oct 14, 2023
Merged

Conversation

marfavi
Copy link
Member

@marfavi marfavi commented Oct 12, 2023

After merging this branch, the develop should be renamed into main, and the production branch should be removed.

A version is released by creating a release with a new appropriately-named tag.

Development versions would be released off of every new push onto the main branch.

Note: in release-dev/release-prod, token is deprecated. Use serviceCredentialsFileContent instead

@ghost
Copy link

ghost commented Oct 12, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@marfavi marfavi changed the title Release dev/prod versions off the main branch Release dev/prod versions off a main branch Oct 12, 2023
TTA777
TTA777 previously requested changes Oct 12, 2023
.github/workflows/release-dev.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
Copy link
Member

@jonasanker jonasanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this work also the build flow must be changed. Previously we signed the apps for prod builds, and handled it differently for the dev app. Since the condition for production branches is not valid any more, we must rewrite the build part again to handle two types of building the app

.github/workflows/release-dev.yml Outdated Show resolved Hide resolved
.github/workflows/release-prod.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b18b921) 73.93% compared to head (3c41c1c) 73.93%.

❗ Current head 3c41c1c differs from pull request most recent head e77734c. Consider uploading reports for the commit e77734c to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #517   +/-   ##
========================================
  Coverage    73.93%   73.93%           
========================================
  Files          128      128           
  Lines         1527     1527           
========================================
  Hits          1129     1129           
  Misses         398      398           
Flag Coverage Δ
unittests 73.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jonasanker
jonasanker previously approved these changes Oct 14, 2023
Copy link
Member

@jonasanker jonasanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😇

@jonasanker jonasanker merged commit 5e44b2d into develop Oct 14, 2023
@jonasanker jonasanker deleted the tag-release-workflow branch October 14, 2023 20:31
@jonasanker jonasanker linked an issue Oct 14, 2023 that may be closed by this pull request
@jonasanker jonasanker mentioned this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New strategy for branches, commits, and releasing
3 participants