Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace Redeem Voucher with v2 endpoint #504

Merged
merged 4 commits into from
Sep 14, 2023
Merged

replace Redeem Voucher with v2 endpoint #504

merged 4 commits into from
Sep 14, 2023

Conversation

fremartini
Copy link
Member

closes #500

@ghost
Copy link

ghost commented Sep 5, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@fremartini fremartini requested a review from a team September 5, 2023 14:38
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 88.18% and project coverage change: +5.27% 🎉

Comparison is base (4aed248) 79.58% compared to head (e1dba2d) 84.85%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #504      +/-   ##
===========================================
+ Coverage    79.58%   84.85%   +5.27%     
===========================================
  Files          114      114              
  Lines         1195     1195              
===========================================
+ Hits           951     1014      +63     
+ Misses         244      181      -63     
Flag Coverage Δ
unittests 84.85% <88.18%> (+5.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ening_hours/domain/usecases/check_open_status.dart 100.00% <ø> (ø)
..._hours/presentation/cubit/opening_hours_cubit.dart 100.00% <ø> (ø)
...atures/register/domain/usecases/register_user.dart 80.00% <ø> (ø)
...user/domain/usecases/request_account_deletion.dart 100.00% <ø> (ø)
...user/data/datasources/user_remote_data_source.dart 56.25% <53.33%> (-2.58%) ⬇️
.../data/datasources/purchase_remote_data_source.dart 75.00% <70.00%> (+11.36%) ⬆️
...r/data/datasources/voucher_remote_data_source.dart 83.33% <75.00%> (+3.33%) ⬆️
...e/data/datasources/account_remote_data_source.dart 83.33% <81.25%> (+7.14%) ⬆️
...ta/datasources/leaderboard_remote_data_source.dart 64.28% <85.71%> (+7.14%) ⬆️
lib/core/network/network_request_executor.dart 100.00% <100.00%> (ø)
... and 12 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@marfavi marfavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update branch + another very small comment

Copy link
Member

@marfavi marfavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small

@fremartini fremartini requested a review from marfavi September 14, 2023 12:40
Copy link
Member

@marfavi marfavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@fremartini fremartini merged commit f32e93e into develop Sep 14, 2023
@fremartini fremartini deleted the voucher_v2 branch September 14, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update voucher_remote_data_source to make use of the V2 endpoint instead
2 participants