Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump packages; fix tests broken by Mockito #501

Merged
merged 8 commits into from
Aug 29, 2023

Conversation

fremartini
Copy link
Member

No description provided.

@fremartini fremartini requested a review from a team August 29, 2023 16:58
@ghost
Copy link

ghost commented Aug 29, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

duckth
duckth previously approved these changes Aug 29, 2023
@duckth
Copy link
Member

duckth commented Aug 29, 2023

lgtm when format is fix

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #501 (a39735d) into develop (a493510) will decrease coverage by 0.39%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #501      +/-   ##
===========================================
- Coverage    79.96%   79.58%   -0.39%     
===========================================
  Files          115      114       -1     
  Lines         1218     1195      -23     
===========================================
- Hits           974      951      -23     
  Misses         244      244              
Flag Coverage Δ
unittests 79.58% <100.00%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib/utils/throttler.dart 100.00% <100.00%> (ø)

@fremartini fremartini enabled auto-merge (squash) August 29, 2023 18:00
Copy link
Member

@marfavi marfavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@fremartini fremartini merged commit 4aed248 into develop Aug 29, 2023
@fremartini fremartini deleted the frem/bump_packages_fix_tests branch August 29, 2023 18:04
@marfavi marfavi changed the title bump packages fix tests broken by Mockito bump packages; fix tests broken by Mockito Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants