fix: Avoid type casting 204 return types from API (#479)

AnalogIO · May 27, 2023 · 75a22dc · 75a22dc
1 parent 82c5bc3
commit 75a22dc
Showing 1 changed file with 4 additions and 12 deletions.
diff --git a/lib/features/receipt/data/datasources/receipt_remote_data_source.dart b/lib/features/receipt/data/datasources/receipt_remote_data_source.dart
@@ -27,17 +27,9 @@ class ReceiptRemoteDataSource {
 
   /// Retrieves all of the users purchase receipts
   Future<Either<Failure, List<Receipt>>> getUserPurchasesReceipts() async {
-    // The API CAN return null if the user has no tickets,
-    // but the generator doesn't pick up on this, hence the type parameter
-    return executor<List<SimplePurchaseResponse>?>(
-      apiV2.apiV2PurchasesGet,
-    ).bindFuture((result) {
-      // If the user has no purchases, the API returns 204 No Content (body is
-      // null). The generator is bad and doesn't handle this case
-      if (result == null) return List<Receipt>.empty();
-      return result
-          .map(PurchaseReceiptModel.fromSimplePurchaseResponse)
-          .toList();
-    });
+    return executor(apiV2.apiV2PurchasesGet).bindFuture(
+      (result) =>
+          result.map(PurchaseReceiptModel.fromSimplePurchaseResponse).toList(),
+    );
   }
 }