Make changes required by gmp api. #262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dvc94ch
commented
Oct 14, 2024
dvc94ch
commented
- mnemonic instead of keyfile
- balance takes an address
- static lifetime finalized block stream
- mnemonic instead of keyfile - balance takes an address - static lifetime finalized block stream
agryaznov
requested changes
Feb 12, 2025
rosetta-client/src/lib.rs
Outdated
| @@ -53,6 +58,8 @@ pub enum Blockchain { | |||
| Avalanche, | |||
| /// Base | |||
| Base, | |||
| /// Anvil | |||
There was a problem hiding this comment.
Anvil is not a blockchain. I'd better leave the connector as is, and make required changes in evm backend, specifically here to pass in a private key
agryaznov
reviewed
Feb 12, 2025
rosetta-client/src/client.rs
Outdated
| | Blockchain::Avalanche => { | ||
| let private_key = if blockchain == Blockchain::Anvil { | ||
| Some(hex_literal::hex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.