Libloading support #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial update to the `libloading` feature, added the support for it in the `sys` crate, this works well. But the main crate is failing to build because of the changes introduced here. We changed how we generate the bindings, used a small crate `generate` to do that instead of using `bindgen` binary in a shell script. What we do, is generate `load`/`link` bindings for `ultralight` libs and `appcore` lib, and we can allow the user to choose whether to include `appcore` or not during `loading` or `linking` Signed-off-by: Amjad Alsharafi <[email protected]>
This new struct, `Library` holds the ultralight library. Its an abstraction that covers `linked` and `loaded` versions, so which version you choose to use, the rest of the code will be the same. The issue with this now is that `ultralight` by design (since we use the C API) relies on global variables and things are done in the form of `platform::instance().do_something` i.e. singletons. With the introduction of this variable (library) that must be used at all times, it makes using the library a bit more complicated. We need to think of a better way to do these stuff. Examples are still failing, will be fixed next. Signed-off-by: Amjad Alsharafi <[email protected]>
Signed-off-by: Amjad Alsharafi <[email protected]>
Signed-off-by: Amjad Alsharafi <[email protected]>
Signed-off-by: Amjad Alsharafi <[email protected]>
Signed-off-by: Amjad Alsharafi <[email protected]>
Signed-off-by: Amjad Alsharafi <[email protected]>
Signed-off-by: Amjad Alsharafi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5
Implements libloading support, allows the user to specify
linkedorloadedfeatures and use the library based on those.The
loadedfeature allow you to load theultralightlibrary at runtime and thus doesn't require explicit linking to these libraries.Like, you can download and load the libraries at runtime while the game/app is running.