fix: correctly infer the type of the function passed to derived #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the type of the function passed to derived was not correctly inferred by typescript in the async case. By putting the async case first in the list of overloads of the derived function, it looks like it fixes the issue, and the type is still correctly inferred in the sync case too.
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
=======================================
Coverage 98.85% 98.85%
=======================================
Files 1 1
Lines 174 174
Branches 32 32
=======================================
Hits 172 172
Partials 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Cf the similar PR in svelte: sveltejs/svelte#5935 |
|
@fbasso Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the type of the function passed to derived was not correctly inferred by typescript in the async case. By putting the async case first in the list of overloads of the derived function, it looks like it fixes the issue, and the type is still correctly inferred in the sync case too.